Skip to content

Conversation

@erezrokah
Copy link
Contributor

@erezrokah erezrokah commented Jul 5, 2020

Fixes https://github.com/netlify-labs/netlify-plugin-lighthouse/issues/37

See https://github.com/GoogleChrome/chrome-launcher/blob/master/docs/chrome-flags-for-tools.md and puppeteer/puppeteer#1834

This fixes the issue, but it looks like the performance category returns null due to the videos in the site.
Tried using --autoplay-policy=user-gesture-required # Don't render video but didn't work.
Seems like a Lighthouse issue.

@erezrokah erezrokah merged commit 48e55ee into master Jul 5, 2020
@erezrokah erezrokah deleted the fix/chrome_in_docker branch July 5, 2020 15:29
@erezrokah
Copy link
Contributor Author

🎉 This PR is included in version 1.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LHError: Failed with error: PROTOCOL_TIMEOUT

2 participants